• Tom Lane's avatar
    Mark index-constraint comments with correct dependency in pg_dump. · 9ef86cd9
    Tom Lane authored
    When there's a comment on an index that was created with UNIQUE or PRIMARY
    KEY constraint syntax, we need to label the comment as depending on the
    constraint not the index, since only the constraint object actually appears
    in the dump.  This incorrect dependency can lead to parallel pg_restore
    trying to restore the comment before the index has been created, per bug
    #8257 from Lloyd Albin.
    
    This patch fixes pg_dump to produce the right dependency in dumps made
    in the future.  Usually we also try to hack pg_restore to work around
    bogus dependencies, so that existing (wrong) dumps can still be restored in
    parallel mode; but that doesn't seem practical here since there's no easy
    way to relate the constraint dump entry to the comment after the fact.
    
    Andres Freund
    9ef86cd9
pg_dump.c 445 KB