• Tom Lane's avatar
    Remove broken and useless entry-count printing in HASH_DEBUG code. · 9d4e5669
    Tom Lane authored
    init_htab(), with #define HASH_DEBUG, prints a bunch of hashtable
    parameters.  It used to also print nentries, but commit 44ca4022 changed
    that to "hash_get_num_entries(hctl)", which is wrong (the parameter should
    be "hashp").
    
    Rather than correct the coding, though, let's just remove that field from
    the printout.  The table must be empty, since we just finished building
    it, so expensively calculating the number of entries is rather pointless.
    Moreover hash_get_num_entries makes assumptions (about not needing locks)
    which we could do without in debugging code.
    
    Noted by Choi Doo-Won in bug #14764.  Back-patch to 9.6 where the
    faulty code was introduced.
    
    Discussion: https://postgr.es/m/20170802032353.8424.12274@wrigleys.postgresql.org
    9d4e5669
dynahash.c 53.8 KB