• Tom Lane's avatar
    Fix a recently-introduced race condition in LISTEN/NOTIFY handling. · 9c83b54a
    Tom Lane authored
    Commit 566372b3 fixed some race conditions involving concurrent
    SimpleLruTruncate calls, but it introduced new ones in async.c.
    A newly-listening backend could attempt to read Notify SLRU pages that
    were in process of being truncated, possibly causing an error.  Also,
    the QUEUE_TAIL pointer could become set to a value that's not equal to
    the queue position of any backend.  While that's fairly harmless in
    v13 and up (thanks to commit 51004c71), in older branches it resulted
    in near-permanent disabling of the queue truncation logic, so that
    continued use of NOTIFY led to queue-fill warnings and eventual
    inability to send any more notifies.  (A server restart is enough to
    make that go away, but it's still pretty unpleasant.)
    
    The core of the problem is confusion about whether QUEUE_TAIL
    represents the "logical" tail of the queue (i.e., the oldest
    still-interesting data) or the "physical" tail (the oldest data we've
    not yet truncated away).  To fix, split that into two variables.
    QUEUE_TAIL regains its definition as the logical tail, and we
    introduce a new variable to track the oldest un-truncated page.
    
    Per report from Mikael Gustavsson.  Like the previous patch,
    back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/1b8561412e8a4f038d7a491c8b922788@smhi.se
    9c83b54a
async.c 75.7 KB