• Tom Lane's avatar
    Fix mishandling of system columns in FDW queries. · 9c581011
    Tom Lane authored
    postgres_fdw would send query conditions involving system columns to the
    remote server, even though it makes no effort to ensure that system
    columns other than CTID match what the remote side thinks.  tableoid,
    in particular, probably won't match and might have some use in queries.
    Hence, prevent sending conditions that include non-CTID system columns.
    
    Also, create_foreignscan_plan neglected to check local restriction
    conditions while determining whether to set fsSystemCol for a foreign
    scan plan node.  This again would bollix the results for queries that
    test a foreign table's tableoid.
    
    Back-patch the first fix to 9.3 where postgres_fdw was introduced.
    Back-patch the second to 9.2.  The code is probably broken in 9.1 as
    well, but the patch doesn't apply cleanly there; given the weak state
    of support for FDWs in 9.1, it doesn't seem worth fixing.
    
    Etsuro Fujita, reviewed by Ashutosh Bapat, and somewhat modified by me
    9c581011
createplan.c 143 KB