• Tom Lane's avatar
    Improve the handling of SET CONSTRAINTS commands by having them search · 9a915e59
    Tom Lane authored
    pg_constraint before searching pg_trigger.  This allows saner handling of
    corner cases; in particular we now say "constraint is not deferrable"
    rather than "constraint does not exist" when the command is applied to
    a constraint that's inherently non-deferrable.  Per a gripe several months
    ago from hubert depesz lubaczewski.
    
    To make this work without breaking user-defined constraint triggers,
    we have to add entries for them to pg_constraint.  However, in return
    we can remove the pgconstrname column from pg_constraint, which represents
    a fairly sizable space savings.  I also replaced the tgisconstraint column
    with tgisinternal; the old meaning of tgisconstraint can now be had by
    testing for nonzero tgconstraint, while there is no other way to get
    the old meaning of nonzero tgconstraint, namely that the trigger was
    internally generated rather than being user-created.
    
    In passing, fix an old misstatement in the docs and comments, namely that
    pg_trigger.tgdeferrable is exactly redundant with pg_constraint.condeferrable.
    Actually, we mark RI action triggers as nondeferrable even when they belong to
    a nominally deferrable FK constraint.  The SET CONSTRAINTS code now relies on
    that instead of hard-coding a list of exception OIDs.
    9a915e59
trigger.h 6.18 KB