• Tom Lane's avatar
    Fix portability issue in pg_upgrade test script: avoid $PWD. · 9a8f5833
    Tom Lane authored
    SUSv2-era shells don't set the PWD variable, though anything more modern
    does.  In the buildfarm environment this could lead to test.sh executing
    with PWD pointing to $HOME or another high-level directory, so that there
    were conflicts between concurrent executions of the test in different
    branch subdirectories.  This appears to be the explanation for recent
    intermittent failures on buildfarm members binturong and dingo (and might
    well have something to do with the buildfarm script's failure to capture
    log files from pg_upgrade tests, too).
    
    To fix, just use `pwd` in place of $PWD.  AFAICS test.sh is the only place
    in our source tree that depended on $PWD.  Back-patch to all versions
    containing this script.
    
    Per buildfarm.  Thanks to Oskari Saarenmaa for diagnosing the problem.
    9a8f5833
test.sh 6.05 KB