• Tom Lane's avatar
    Remove CatalogCacheFlushRelation, and the reloidattr infrastructure that was · 9a75803b
    Tom Lane authored
    needed by nothing else.
    
    The restructuring I just finished doing on cache management exposed to me how
    silly this routine was.  Its function was to go into the catcache and blow
    away all entries related to a given relation when there was a relcache flush
    on that relation.  However, there is no point in removing a catcache entry
    if the catalog row it represents is still valid --- and if it isn't valid,
    there must have been a catcache entry flush on it, because that's triggered
    directly by heap_update or heap_delete on the catalog row.  So this routine
    accomplished nothing except to blow away valid cache entries that we'd very
    likely be wanting in the near future to help reconstruct the relcache entry.
    Dumb.
    
    On top of which, it required a subtle and easy-to-get-wrong attribute in
    syscache definitions, ie, the column containing the OID of the related
    relation if any.  Removing that is a very useful maintenance simplification.
    9a75803b
catcache.h 7.41 KB