• Peter Eisentraut's avatar
    Fix several one-byte buffer over-reads in to_number · 9a46324f
    Peter Eisentraut authored
    Several places in NUM_numpart_from_char(), which is called from the SQL
    function to_number(text, text), could accidentally read one byte past
    the end of the input buffer (which comes from the input text datum and
    is not null-terminated).
    
    1. One leading space character would be skipped, but there was no check
       that the input was at least one byte long.  This does not happen in
       practice, but for defensiveness, add a check anyway.
    
    2. Commit 4a3a1e2c apparently accidentally doubled that code that skips
       one space character (so that two spaces might be skipped), but there
       was no overflow check before skipping the second byte.  Fix by
       removing that duplicate code.
    
    3. A logic error would allow a one-byte over-read when looking for a
       trailing sign (S) placeholder.
    
    In each case, the extra byte cannot be read out directly, but looking at
    it might cause a crash.
    
    The third item was discovered by Piotr Stefaniak, the first two were
    found and analyzed by Tom Lane and Peter Eisentraut.
    9a46324f
formatting.c 133 KB