• Michael Paquier's avatar
    Remove XLogFileNameP() from the tree · 9989d37d
    Michael Paquier authored
    XLogFileNameP() is a wrapper routine able to build a palloc'd string for
    a WAL segment name, which is used for error string generation.  There
    were several code paths where it gets called in a critical section,
    where memory allocation is not allowed.  This results in triggering
    an assertion failure instead of generating the wanted error message.
    
    Another, more annoying, problem is that if the allocation to generate
    the WAL segment name fails on OOM, then the failure would be escalated
    to a PANIC.
    
    This removes the routine and all its callers are replaced with a logic
    using a fixed-size buffer.  This way, all the existing mistakes are
    fixed and future ones are prevented.
    
    Author: Masahiko Sawada
    Reviewed-by: Michael Paquier, Álvaro Herrera
    Discussion: https://postgr.es/m/CA+fd4k5gC9H4uoWMLg9K_QfNrnkkdEw+-AFveob9YX7z8JnKTA@mail.gmail.com
    9989d37d
xlog.c 383 KB