• Tom Lane's avatar
    Adjust datatype of ReplicationState.acquired_by. · 994f1125
    Tom Lane authored
    It was declared as "pid_t", which would be fine except that none of
    the places that printed it in error messages took any thought for the
    possibility that it's not equivalent to "int".  This leads to warnings
    on some buildfarm members, and could possibly lead to actually wrong
    error messages on those platforms.  There doesn't seem to be any very
    good reason not to just make it "int"; it's only ever assigned from
    MyProcPid, which is int.  If we want to cope with PIDs that are wider
    than int, this is not the place to start.
    
    Also, fix the comment, which seems to perhaps be a leftover from a time
    when the field was only a bool?
    
    Per buildfarm.  Back-patch to 9.5 which has same issue.
    994f1125
origin.c 38.8 KB