• Fujii Masao's avatar
    Remove files signaling a standby promotion request at postmaster startup · 96f6a0cb
    Fujii Masao authored
    This commit makes postmaster forcibly remove the files signaling
    a standby promotion request. Otherwise, the existence of those files
    can trigger a promotion too early, whether a user wants that or not.
    
    This removal of files is usually unnecessary because they can exist
    only during a few moments during a standby promotion. However
    there is a race condition: if pg_ctl promote is executed and creates
    the files during a promotion, the files can stay around even after
    the server is brought up to new master. Then, if new standby starts
    by using the backup taken from that master, the files can exist
    at the server startup and should be removed in order to avoid
    an unexpected promotion.
    
    Back-patch to 9.1 where promote signal file was introduced.
    
    Problem reported by Feike Steenbergen.
    Original patch by Michael Paquier, modified by me.
    
    Discussion: 20150528100705.4686.91426@wrigleys.postgresql.org
    96f6a0cb
xlog.h 10.1 KB