• Michael Paquier's avatar
    Simplify tests of postgres_fdw terminating connections · 93f41461
    Michael Paquier authored
    The tests introduced in 32a9c0bd for connections broken and
    re-established rely on pg_terminate_backend() for their logic.  When
    these were introduced, this function simply sent a signal to a backend
    without waiting for the operation to complete, and the tests repeatedly
    looked at pg_stat_activity to check if the operation was completed or
    not.  Since aaf04325, it is possible to define a timeout to make
    pg_terminate_backend() wait for a certain duration, so make use of it,
    with a timeout reasonably large enough (3min) to give enough room for
    the tests to pass even on slow machines.
    
    Some measurements show that the tests of postgres_fdw are much faster
    with this change.  For example, on my laptop, they now take 4s instead
    of 6s.
    
    Author: Bharath Rupireddy
    Discussion: https://postgr.es/m/CALj2ACXGY_EfGrMTjKjHy2zi-u1u9rdeioU_fro0T6Jo8t56KQ@mail.gmail.com
    93f41461
postgres_fdw.out 486 KB