• Tom Lane's avatar
    Fix up memory management problems in contrib/xml2. · 936c4af1
    Tom Lane authored
    Get rid of the code that attempted to funnel libxml2's memory allocations
    into palloc.   We already knew from experience with the core xml datatype
    that trying to do this is simply not reliable.  Unlike the core code, I
    did not bother adding a lot of PG_TRY/PG_CATCH logic to try to ensure that
    everything is cleaned up on error exit.  Hence, we might leak some memory
    if one of these functions fails partway through.  Given the deprecated
    status of this contrib module and the fact that errors partway through
    the functions shouldn't be too common, it doesn't seem worth worrying about.
    
    Also fix a separate bug in xpath_table, that it did the wrong things
    if given a result tuple descriptor with less than 2 columns.  While
    such a case isn't very useful in practice, we shouldn't fail or stomp
    memory when it occurs.
    
    Add some simple regression tests based on all the reported crash cases
    that I have on hand.
    
    This should be back-patched, but let's see if the buildfarm likes it first.
    936c4af1
xml2.out 5.22 KB