• Tom Lane's avatar
    Fix translatability markings in psql, and add defenses against future bugs. · 92459e7a
    Tom Lane authored
    Several previous commits have added columns to various \d queries without
    updating their translate_columns[] arrays, leading to potentially incorrect
    translations in NLS-enabled builds.  Offenders include commit 89368676
    (added prosecdef to \df+), c9ac00e6 (added description to \dc+) and
    3b17efdf (added description to \dC+).  Fix those cases back to 9.3 or
    9.2 as appropriate.
    
    Since this is evidently more easily missed than one would like, in HEAD
    also add an Assert that the supplied array is long enough.  This requires
    an API change for printQuery(), so it seems inappropriate for back
    branches, but presumably all future changes will be tested in HEAD anyway.
    
    In HEAD and 9.3, also clean up a whole lot of sloppiness in the emitted
    SQL for \dy (event triggers): lack of translatability due to failing to
    pass words-to-be-translated through gettext_noop(), inadequate schema
    qualification, and sloppy formatting resulting in unnecessarily ugly
    -E output.
    
    Peter Eisentraut and Tom Lane, per bug #8702 from Sergey Burladyan
    92459e7a
describe.c 122 KB