• Tom Lane's avatar
    Fix treatment of *lpNumberOfBytesRecvd == 0: that's a completion condition. · 90e61df8
    Tom Lane authored
    pgwin32_recv() has treated a non-error return of zero bytes from WSARecv()
    as being a reason to block ever since the current implementation was
    introduced in commit a4c40f14.  However, so far as one can tell
    from Microsoft's documentation, that is just wrong: what it means is
    graceful connection closure (in stream protocols) or receipt of a
    zero-length message (in message protocols), and neither case should result
    in blocking here.  The only reason the code worked at all was that control
    then fell into the retry loop, which did *not* treat zero bytes specially,
    so we'd get out after only wasting some cycles.  But as of 9.5 we do not
    normally reach the retry loop and so the bug is exposed, as reported by
    Shay Rojansky and diagnosed by Andres Freund.
    
    Remove the unnecessary test on the byte count, and rearrange the code
    in the retry loop so that it looks identical to the initial sequence.
    
    Back-patch to 9.5.  The code is wrong all the way back, AFAICS, but
    since it's relatively harmless in earlier branches we'll leave it alone.
    90e61df8
socket.c 14.7 KB