• Tom Lane's avatar
    Reduce PANIC to ERROR in some occasionally-reported btree failure cases. · 8fa30f90
    Tom Lane authored
    This patch changes _bt_split() and _bt_pagedel() to throw a plain ERROR,
    rather than PANIC, for several cases that are reported from the field
    from time to time:
    * right sibling's left-link doesn't match;
    * PageAddItem failure during _bt_split();
    * parent page's next child isn't right sibling during _bt_pagedel().
    In addition the error messages for these cases have been made a bit
    more verbose, with additional values included.
    
    The original motivation for PANIC here was to capture core dumps for
    subsequent analysis.  But with so many users whose platforms don't capture
    core dumps by default, or who are unprepared to analyze them anyway, it's hard
    to justify a forced database restart when we can fairly easily detect the
    problems before we've reached the critical sections where PANIC would be
    necessary.  It is not currently known whether the reports of these messages
    indicate well-hidden bugs in Postgres, or are a result of storage-level
    malfeasance; the latter possibility suggests that we ought to try to be more
    robust even if there is a bug here that's ultimately found.
    
    Backpatch to 8.2.  The code before that is sufficiently different that
    it doesn't seem worth the trouble to back-port further.
    8fa30f90
nbtinsert.c 64.9 KB