• Tom Lane's avatar
    Prevent ALTER TYPE/DOMAIN/OPERATOR from changing extension membership. · 8f51ee63
    Tom Lane authored
    If recordDependencyOnCurrentExtension is invoked on a pre-existing,
    free-standing object during an extension update script, that object
    will become owned by the extension.  In our current code this is
    possible in three cases:
    
    * Replacing a "shell" type or operator.
    * CREATE OR REPLACE overwriting an existing object.
    * ALTER TYPE SET, ALTER DOMAIN SET, and ALTER OPERATOR SET.
    
    The first of these cases is intentional behavior, as noted by the
    existing comments for GenerateTypeDependencies.  It seems like
    appropriate behavior for CREATE OR REPLACE too; at least, the obvious
    alternatives are not better.  However, the fact that it happens during
    ALTER is an artifact of trying to share code (GenerateTypeDependencies
    and makeOperatorDependencies) between the CREATE and ALTER cases.
    Since an extension script would be unlikely to ALTER an object that
    didn't already belong to the extension, this behavior is not very
    troubling for the direct target object ... but ALTER TYPE SET will
    recurse to dependent domains, and it is very uncool for those to
    become owned by the extension if they were not already.
    
    Let's fix this by redefining the ALTER cases to never change extension
    membership, full stop.  We could minimize the behavioral change by
    only changing the behavior when ALTER TYPE SET is recursing to a
    domain, but that would complicate the code and it does not seem like
    a better definition.
    
    Per bug #17144 from Alex Kozhemyakin.  Back-patch to v13 where ALTER
    TYPE SET was added.  (The other cases are older, but since they only
    affect the directly-named object, there's not enough of a problem to
    justify changing the behavior further back.)
    
    Discussion: https://postgr.es/m/17144-e67d7a8f049de9af@postgresql.org
    8f51ee63
pg_operator.c 25.3 KB