• Tom Lane's avatar
    Fix connection string handling in src/bin/scripts/ programs. · 8e5793ab
    Tom Lane authored
    When told to process all databases, clusterdb, reindexdb, and vacuumdb
    would reconnect by replacing their --maintenance-db parameter with the
    name of the target database.  If that parameter is a connstring (which
    has been allowed for a long time, though we failed to document that
    before this patch), we'd lose any other options it might specify, for
    example SSL or GSS parameters, possibly resulting in failure to connect.
    Thus, this is the same bug as commit a45bc8a4 fixed in pg_dump and
    pg_restore.  We can fix it in the same way, by using libpq's rules for
    handling multiple "dbname" parameters to add the target database name
    separately.  I chose to apply the same refactoring approach as in that
    patch, with a struct to handle the command line parameters that need to
    be passed through to connectDatabase.  (Maybe someday we can unify the
    very similar functions here and in pg_dump/pg_restore.)
    
    Per Peter Eisentraut's comments on bug #16604.  Back-patch to all
    supported branches.
    
    Discussion: https://postgr.es/m/16604-933f4b8791227b15@postgresql.org
    8e5793ab
vacuumdb.sgml 19.1 KB