• Tom Lane's avatar
    Restore the previous semantics of get_constraint_index(). · 8dcd1c35
    Tom Lane authored
    Commit 8b069ef5 changed this function to look at pg_constraint.conindid
    rather than searching pg_depend.  That was a good performance improvement,
    but it failed to preserve the exact semantics.  The old code would only
    return an index that was "owned by" (internally dependent on) the
    specified constraint, whereas the new code will also return indexes that
    are just referenced by foreign key constraints.  This confuses ALTER
    TABLE, which was implicitly expecting the previous semantics, into
    failing with errors like
        ERROR:  relation 146621 has multiple clustered indexes
    or
        ERROR:  "pk_attbl" is not an index for table "atref"
    
    We can fix this without reverting the performance improvement by adding
    a contype check in get_constraint_index().  Another way could be to
    make ALTER TABLE check it, but I'm worried that extension code could
    also have subtle dependencies on the old semantics.
    
    Tom Lane and Japin Li, per bug #17409 from Holly Roberts.
    Back-patch to v14 where the error crept in.
    
    Discussion: https://postgr.es/m/17409-52871dda8b5741cb@postgresql.org
    8dcd1c35
alter_table.sql 112 KB