• Tom Lane's avatar
    Add Asserts to verify that catalog cache keys are unique and not null. · 8b38a538
    Tom Lane authored
    The catcache code is effectively assuming this already, so let's insist
    that the catalog and index are actually declared that way.
    
    Having done that, the comments in indexing.h about non-unique indexes
    not being used for catcaches are completely redundant not just mostly so;
    and we didn't have such a comment for every such index anyway.  So let's
    get rid of them.
    
    Per discussion of whether we should identify primary keys for catalogs.
    We might or might not take that further step, but this change in itself
    will allow quicker detection of misdeclared catcaches, so it seems worth
    doing in any case.
    8b38a538
indexing.h 16.1 KB