• Tom Lane's avatar
    Try to ensure that stats collector's receive buffer size is at least 100KB. · 8b0b6303
    Tom Lane authored
    Since commit 4e37b3e1, buildfarm member frogmouth has been failing
    occasionally with symptoms indicating that some expected stats data is
    getting dropped.  The reason that that commit changed the behavior seems
    probably to be that more data is getting shoved at the collector in a short
    span of time.  In current sources, the stats test's first session sends
    about 9KB of data while exiting, which is probably the same as what was
    sent just before wait_for_stats() in the previous test design.  But now,
    the test's second session is starting up concurrently, and it sends another
    2KB (presumably reflecting its initial catalog accesses).  Since frogmouth
    is running on Windows XP, which reputedly has a default socket receive
    buffer size of only 8KB, it is not very surprising if this has put us over
    the threshold where the receive buffer can overflow and drop messages.
    
    The same mechanism could very easily explain the intermittent stats test
    failures we've been seeing for years, since background processes such
    as the bgwriter will sometimes send data concurrently with all this, and
    could thus cause occasional buffer overflows.
    
    Hence, insert some code into pgstat_init() to increase the stats socket's
    receive buffer size to 100KB if it's less than that.  (On failure, emit a
    LOG message, but keep going.)  Modern systems seem to have default sizes
    in the range of 100KB-250KB, but older platforms don't.  I couldn't find
    any platforms that wouldn't accept 100KB, so in theory this won't cause
    any portability problems.
    
    If this is successful at reducing the buildfarm failure rate in HEAD,
    we should back-patch it, because it's certain that similar buffer overflows
    happen in the field on platforms with small buffer sizes.  Going forward,
    there might be an argument for trying to increase the buffer size even
    more, but let's take a baby step first.
    
    Discussion: https://postgr.es/m/22173.1494788088@sss.pgh.pa.us
    8b0b6303
pgstat.c 164 KB