• Tom Lane's avatar
    Clear conn->errorMessage at successful completion of PQconnectdb(). · 896a0c44
    Tom Lane authored
    Commits ffa2e467 and 52a10224 caused libpq's connection-establishment
    functions to usually leave a nonempty string in the connection's
    errorMessage buffer, even after a successful connection.  While that
    was intentional on my part, more sober reflection says that it wasn't
    a great idea: the string would be a bit confusing.  Also this broke at
    least one application that checked for connection success by examining
    the errorMessage, instead of using PQstatus() as documented.  Let's
    clear the buffer at success exit, restoring the pre-v14 behavior.
    
    Discussion: https://postgr.es/m/4170264.1620321747@sss.pgh.pa.us
    896a0c44
fe-connect.c 185 KB