• Michael Paquier's avatar
    Fix crash in WAL sender when starting physical replication · 879ad9f9
    Michael Paquier authored
    Since database connections can be used with WAL senders in 9.4, it is
    possible to use physical replication.  This commit fixes a crash when
    starting physical replication with a WAL sender using a database
    connection, caused by the refactoring done in 850196b6.
    
    There have been discussions about forbidding the use of physical
    replication in a database connection, but this is left for later,
    taking care only of the crash new to 13.
    
    While on it, add a test to check for a failure when attempting logical
    replication if the WAL sender does not have a database connection.  This
    part is extracted from a larger patch by Kyotaro Horiguchi.
    
    Reported-by: Vladimir Sitnikov
    Author: Michael Paquier, Kyotaro Horiguchi
    Reviewed-by: Kyotaro Horiguchi, Álvaro Herrera
    Discussion: https://postgr.es/m/CAB=Je-GOWMj1PTPkeUhjqQp-4W3=nW-pXe2Hjax6rJFffB5_Aw@mail.gmail.com
    Backpatch-through: 13
    879ad9f9
walsender.c 104 KB