• Tom Lane's avatar
    Fix assorted core dumps and Assert failures that could occur during · 875353b9
    Tom Lane authored
    AbortTransaction or AbortSubTransaction, when trying to clean up after an
    error that prevented (sub)transaction start from completing:
    * access to TopTransactionResourceOwner that might not exist
    * assert failure in AtEOXact_GUC, if AtStart_GUC not called yet
    * assert failure or core dump in AfterTriggerEndSubXact, if
      AfterTriggerBeginSubXact not called yet
    
    Per testing by injecting elog(ERROR) at successive steps in StartTransaction
    and StartSubTransaction.  It's not clear whether all of these cases could
    really occur in the field, but at least one of them is easily exposed by
    simple stress testing, as per my accidental discovery yesterday.
    875353b9
xact.c 126 KB