• Tom Lane's avatar
    Allow index AMs to cache data across aminsert calls within a SQL command. · 86d911ec
    Tom Lane authored
    It's always been possible for index AMs to cache data across successive
    amgettuple calls within a single SQL command: the IndexScanDesc.opaque
    field is meant for precisely that.  However, no comparable facility
    exists for amortizing setup work across successive aminsert calls.
    This patch adds such a feature and teaches GIN, GIST, and BRIN to use it
    to amortize catalog lookups they'd previously been doing on every call.
    (The other standard index AMs keep everything they need in the relcache,
    so there's little to improve there.)
    
    For GIN, the overall improvement in a statement that inserts many rows
    can be as much as 10%, though it seems a bit less for the other two.
    In addition, this makes a really significant difference in runtime
    for CLOBBER_CACHE_ALWAYS tests, since in those builds the repeated
    catalog lookups are vastly more expensive.
    
    The reason this has been hard up to now is that the aminsert function is
    not passed any useful place to cache per-statement data.  What I chose to
    do is to add suitable fields to struct IndexInfo and pass that to aminsert.
    That's not widening the index AM API very much because IndexInfo is already
    within the ken of ambuild; in fact, by passing the same info to aminsert
    as to ambuild, this is really removing an inconsistency in the AM API.
    
    Discussion: https://postgr.es/m/27568.1486508680@sss.pgh.pa.us
    86d911ec
tuptoaster.c 62.3 KB