• Fujii Masao's avatar
    Make WAL-related utilities handle .partial WAL files properly. · 8650d161
    Fujii Masao authored
    Commit de768844 changed an archive recovery so that the last WAL
    segment with old timeline was renamed with suffix .partial. It should
    have updated WAL-related utilities so that they can handle such
    .paritial WAL files, but we forgot that.
    
    This patch changes pg_archivecleanup so that it can clean up even
    archived WAL files with .partial suffix. Also it allows us to specify
    .partial WAL file name as the command-line argument "oldestkeptwalfile".
    
    This patch also changes pg_resetxlog so that it can remove .partial
    WAL files in pg_xlog directory.
    
    pg_xlogdump cannot handle .partial WAL files. Per discussion,
    we decided only to document that limitation instead of adding the fix.
    Because a user can easily work around the limitation (i.e., just remove
    .partial suffix from the file name) and the fix seems complicated for
    very narrow use case.
    
    Back-patch to 9.5 where the problem existed.
    
    Review by Michael Paquier.
    Discussion: http://www.postgresql.org/message-id/CAHGQGwGxMKnVHGgTfiig2Bt_2djec0in3-DLJmtg7+nEiidFdQ@mail.gmail.com
    8650d161
pg_archivecleanup.c 10.3 KB