• Tom Lane's avatar
    Fix the inadvertent libpq ABI breakage discovered by Martin Pitt: the · 8468146b
    Tom Lane authored
    renumbering of encoding IDs done between 8.2 and 8.3 turns out to break 8.2
    initdb and psql if they are run with an 8.3beta1 libpq.so.  For the moment
    we can rearrange the order of enum pg_enc to keep the same number for
    everything except PG_JOHAB, which isn't a problem since there are no direct
    references to it in the 8.2 programs anyway.  (This does force initdb
    unfortunately.)
    
    Going forward, we want to fix things so that encoding IDs can be changed
    without an ABI break, and this commit includes the changes needed to allow
    libpq's encoding IDs to be treated as fully independent of the backend's.
    The main issue is that libpq clients should not include pg_wchar.h or
    otherwise assume they know the specific values of libpq's encoding IDs,
    since they might encounter version skew between pg_wchar.h and the libpq.so
    they are using.  To fix, have libpq officially export functions needed for
    encoding name<=>ID conversion and validity checking; it was doing this
    anyway unofficially.
    
    It's still the case that we can't renumber backend encoding IDs until the
    next bump in libpq's major version number, since doing so will break the
    8.2-era client programs.  However the code is now prepared to avoid this
    type of problem in future.
    
    Note that initdb is no longer a libpq client: we just pull in the two
    source files we need directly.  The patch also fixes a few places that
    were being sloppy about checking for an unrecognized encoding name.
    8468146b
encnames.c 10.4 KB