• Alvaro Herrera's avatar
    Further tweak commit_timestamp behavior · 820ddb2c
    Alvaro Herrera authored
    As pointed out by Fujii Masao, we weren't quite there on a standby
    behaving sanely: first because we were failing to acquire the correct
    state in the case where no XLOG_PARAMETER_CHANGE message was sent
    (because a checkpoint had already happened after the setting was changed
    in the master, and then the standby was restarted); and second because
    promoting the standby with the feature enabled failed to activate it if
    the master had the feature disabled.
    
    This patch fixes both those misbehaviors hopefully without
    re-introducing any old problems.
    
    Also change the hint emitted in a standby together with the error
    message about the feature being disabled, to make it point out that the
    place to chance the setting is the master.  Otherwise, if the setting is
    already enabled in the standby, it is very confusing to have it say that
    the setting must be enabled ...
    
    Authors: Álvaro Herrera, Petr Jelínek.
    Backpatch to 9.5.
    820ddb2c
xlog.c 358 KB