• Michael Paquier's avatar
    Rework error messages around file handling · 811b6e36
    Michael Paquier authored
    Some error messages related to file handling are using the code path
    context to define their state.  For example, 2PC-related errors are
    referring to "two-phase status files", or "relation mapping file" is
    used for catalog-to-filenode mapping, however those prove to be
    difficult to translate, and are not more helpful than just referring to
    the path of the file being worked on.  So simplify all those error
    messages by just referring to files with their path used.  In some
    cases, like the manipulation of WAL segments, the context is actually
    helpful so those are kept.
    
    Calls to the system function read() have also been rather inconsistent
    with their error handling sometimes not reporting the number of bytes
    read, and some other code paths trying to use an errno which has not
    been set.  The in-core functions are using a more consistent pattern
    with this patch, which checks for both errno if set or if an
    inconsistent read is happening.
    
    So as to care about pluralization when reading an unexpected number of
    byte(s), "could not read: read %d of %zu" is used as error message, with
    %d field being the output result of read() and %zu the expected size.
    This simplifies the work of translators with less variations of the same
    message.
    
    Author: Michael Paquier
    Reviewed-by: Álvaro Herrera
    Discussion: https://postgr.es/m/20180520000522.GB1603@paquier.xyz
    811b6e36
relmapper.c 27.5 KB