• Tom Lane's avatar
    Repair memory leakage while ANALYZE-ing complex index expressions. · 80fb2c1f
    Tom Lane authored
    The general design of memory management in Postgres is that intermediate
    results computed by an expression are not freed until the end of the tuple
    cycle.  For expression indexes, ANALYZE has to re-evaluate each expression
    for each of its sample rows, and it wasn't bothering to free intermediate
    results until the end of processing of that index.  This could lead to very
    substantial leakage if the intermediate results were large, as in a recent
    example from Jakub Ouhrabka.  Fix by doing ResetExprContext for each sample
    row.  This necessitates adding a datumCopy step to ensure that the final
    expression value isn't recycled too.  Some quick testing suggests that this
    change adds at worst about 10% to the time needed to analyze a table with
    an expression index; which is annoying, but seems a tolerable price to pay
    to avoid unexpected out-of-memory problems.
    
    Back-patch to all supported branches.
    80fb2c1f
analyze.c 78.9 KB