• Tom Lane's avatar
    Make pg_upgrade's test script attempt to select a non-conflicting port. · 7e2b1c03
    Tom Lane authored
    Previously, the port number used in this test script was hard-wired at
    pg_upgrade's default of 50432; which is not so great because parallel build
    runs might conflict.  Commit 3d53173e
    removed this setting for the postmasters started by the script proper
    (not by pg_upgrade), which didn't do anything to fix that problem and also
    guaranteed a failure if there was a live postmaster at the build's default
    port number.  Instead, select a non-conflicting temporary port number in
    the same way that pg_regress.c does.  (Its method isn't entirely
    bulletproof, but given the lack of complaints I'm not going to worry
    about that today.)
    
    In passing, unset MAKEFLAGS and MAKELEVEL to avoid problems with the
    script's internal invocations of make, for the same reason pg_regress.c
    does: it could cause problems in a parallel make.
    7e2b1c03
test.sh 4.69 KB