• Noah Misch's avatar
    Revive "snapshot too old" with wal_level=minimal and SET TABLESPACE. · 7da83415
    Noah Misch authored
    Given a permanent relation rewritten in the current transaction, the
    old_snapshot_threshold mechanism assumed the relation had never been
    subject to early pruning.  Hence, a query could fail to report "snapshot
    too old" when the rewrite followed an early truncation.  ALTER TABLE SET
    TABLESPACE is probably the only rewrite mechanism capable of exposing
    this bug.  REINDEX sets indcheckxmin, avoiding the problem.  CLUSTER has
    zeroed page LSNs since before old_snapshot_threshold existed, so
    old_snapshot_threshold has never cooperated with it.  ALTER TABLE
    ... SET DATA TYPE makes the table look empty to every past snapshot,
    which is strictly worse.  Back-patch to v13, where commit
    c6b92041 broke this.
    
    Kyotaro Horiguchi and Noah Misch
    
    Discussion: https://postgr.es/m/20210113.160705.2225256954956139776.horikyota.ntt@gmail.com
    7da83415
snapmgr.h 6.64 KB