• Tom Lane's avatar
    Avoid using SplitIdentifierString to parse ListenAddresses, too. · 7bf40ea0
    Tom Lane authored
    This gets rid of our former behavior of forcibly downcasing
    the postmaster's hostname list and truncating the elements to
    NAMEDATALEN.  In principle, DNS hostnames are case-insensitive
    so the first behavior should be harmless, and server hostnames
    are seldom long enough for the second behavior to be an issue.
    But it's still dubious, and an easy fix is available: just use
    SplitGUCList instead.
    
    AFAICT, all other SplitIdentifierString calls in the backend are
    OK: either the items actually are SQL identifiers, or they are
    keywords that are short and case-insensitive.
    
    Per thinking about bug #16106.  While this has been wrong for
    a very long time, the lack of field complaints means there's
    little reason to back-patch.
    
    Discussion: https://postgr.es/m/16106-7d319e4295d08e70@postgresql.org
    7bf40ea0
postmaster.c 184 KB