• Tom Lane's avatar
    Avoid ecpglib core dump with out-of-order operations. · 7bc21ed8
    Tom Lane authored
    If an application executed operations like EXEC SQL PREPARE
    without having first established a database connection, it could
    get a core dump instead of the expected clean failure.  This
    occurred because we did "pthread_getspecific(actual_connection_key)"
    without ever having initialized the TSD key actual_connection_key.
    The results of that are probably platform-specific, but at least
    on Linux it often leads to a crash.
    
    To fix, add calls to ecpg_pthreads_init() in the code paths that
    might use actual_connection_key uninitialized.  It's harmless
    (and hopefully inexpensive) to do that more than once.
    
    Per bug #17514 from Okano Naoki.  The problem's ancient, so
    back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/17514-edd4fad547c5692c@postgresql.org
    7bc21ed8
connect.c 16.8 KB