• Tom Lane's avatar
    Get rid of USE_WIDE_UPPER_LOWER dependency in trigram construction. · 7844608e
    Tom Lane authored
    contrib/pg_trgm's make_trigrams() was coded to ignore multibyte character
    boundaries and just make trigrams from bytes if USE_WIDE_UPPER_LOWER wasn't
    defined.  This is a bit odd, since there's no obvious reason why trigram
    compaction rules should depend on the presence of towlower() and friends.
    What's more, there was an Assert() that would fail if that code path was
    fed any multibyte characters.
    
    We need to do something about this since the pending regex-indexing patch
    has an assumption that you get just one "trgm" from any three characters.
    The best solution seems to be to remove the USE_WIDE_UPPER_LOWER
    dependency, which shouldn't really have been there in the first place.
    The second loop in make_trigrams() is now just a fast path and not a
    potentially incompatible algorithm.
    
    If there is anybody still using Postgres on machines without wcstombs() or
    towlower(), and they have non-ASCII data indexed by pg_trgm, they'll need
    to REINDEX those indexes after pg_upgrade to 9.3, else searches may fail
    incorrectly. It seems likely that there are no such installations, though.
    
    In passing, rename cnt_trigram to compact_trigram, which seems to better
    describe its functionality, and improve make_trigrams' test for whether it
    has to use the slow path or not (per a suggestion from Alexander Korotkov).
    7844608e
trgm_op.c 12.5 KB