• Tom Lane's avatar
    Fix behavior when converting a float infinity to numeric. · 7769fc00
    Tom Lane authored
    float8_numeric() and float4_numeric() failed to consider the possibility
    that the input is an IEEE infinity.  The results depended on the
    platform-specific behavior of sprintf(): on most platforms you'd get
    something like
    
    ERROR:  invalid input syntax for type numeric: "inf"
    
    but at least on Windows it's possible for the conversion to succeed and
    deliver a finite value (typically 1), due to a nonstandard output format
    from sprintf and lack of syntax error checking in these functions.
    
    Since our numeric type lacks the concept of infinity, a suitable conversion
    is impossible; the best thing to do is throw an explicit error before
    letting sprintf do its thing.
    
    While at it, let's use snprintf not sprintf.  Overrunning the buffer
    should be impossible if sprintf does what it's supposed to, but this
    is cheap insurance against a stack smash if it doesn't.
    
    Problem reported by Taiki Kondo.  Patch by me based on fix suggestion
    from KaiGai Kohei.  Back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/12A9442FBAE80D4E8953883E0B84E088C8C7A2@BPXM01GP.gisp.nec.co.jp
    7769fc00
numeric.c 221 KB