• Andres Freund's avatar
    Fix mdtruncate() to close fd.c handle of deleted segments. · 769fd9d8
    Andres Freund authored
    mdtruncate() forgot to FileClose() a segment's mdfd_vfd, when deleting
    it. That lead to a fd.c handle to a truncated file being kept open until
    backend exit.
    
    The issue appears to have been introduced way back in 1a5c450f,
    before that the handle was closed inside FileUnlink().
    
    The impact of this bug is limited - only VACUUM and ON COMMIT TRUNCATE
    for temporary tables, truncate files in place (i.e. TRUNCATE itself is
    not affected), and the relation has to be bigger than 1GB. The
    consequences of a leaked fd.c handle aren't severe either.
    
    Discussion: <20160908220748.oqh37ukwqqncbl3n@alap3.anarazel.de>
    Backpatch: all supported releases
    769fd9d8
md.c 58.3 KB