• Michael Paquier's avatar
    Fix error handling of vacuumdb and reindexdb when running out of fds · 71d84efb
    Michael Paquier authored
    When trying to use a high number of jobs, vacuumdb (and more recently
    reindexdb) has only checked for a maximum number of jobs used, causing
    confusing failures when running out of file descriptors when the jobs
    open connections to Postgres.  This commit changes the error handling so
    as we do not check anymore for a maximum number of allowed jobs when
    parsing the option value with FD_SETSIZE, but check instead if a file
    descriptor is within the supported range when opening the connections
    for the jobs so as this is detected at the earliest time possible.
    
    Also, improve the error message to give a hint about the number of jobs
    recommended, using a wording given by the reviewers of the patch.
    
    Reported-by: Andres Freund
    Author: Michael Paquier
    Reviewed-by: Andres Freund, Álvaro Herrera, Tom Lane
    Discussion: https://postgr.es/m/20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.de
    Backpatch-through: 9.5
    71d84efb
scripts_parallel.c 6.47 KB