• Tom Lane's avatar
    Fix overly-strict assertions in spgtextproc.c. · 7157fe80
    Tom Lane authored
    spg_text_inner_consistent is capable of reconstructing an empty string
    to pass down to the next index level; this happens if we have an empty
    string coming in, no prefix, and a dummy node label.  (In practice, what
    is needed to trigger that is insertion of a whole bunch of empty-string
    values.)  Then, we will arrive at the next level with in->level == 0
    and a non-NULL (but zero length) in->reconstructedValue, which is valid
    but the Assert tests weren't expecting it.
    
    Per report from Andreas Seltenreich.  This has no impact in non-Assert
    builds, so should not be a problem in production, but back-patch to
    all affected branches anyway.
    
    In passing, remove a couple of useless variable initializations and
    shorten the code by not duplicating DatumGetPointer() calls.
    7157fe80
spgtextproc.c 18.1 KB