• Amit Kapila's avatar
    Fix assertion during streaming of multi-insert toast changes. · 6f4bdf81
    Amit Kapila authored
    While decoding the multi-insert WAL we can't clean the toast untill we get
    the last insert of that WAL record. Now if we stream the changes before we
    get the last change, the memory for toast chunks won't be released and we
    expect the txn to have streamed all changes after streaming.  This
    restriction is mainly to ensure the correctness of streamed transactions
    and it doesn't seem worth uplifting such a restriction just to allow this
    case because anyway we will stream the transaction once such an insert is
    complete.
    
    Previously we were using two different flags (one for toast tuples and
    another for speculative inserts) to indicate partial changes. Now instead
    we replaced both of them with a single flag to indicate partial changes.
    
    Reported-by: Pavan Deolasee
    Author: Dilip Kumar
    Reviewed-by: Pavan Deolasee, Amit Kapila
    Discussion: https://postgr.es/m/CABOikdN-_858zojYN-2tNcHiVTw-nhxPwoQS4quExeweQfG1Ug@mail.gmail.com
    6f4bdf81
stream.out 3.91 KB