• Tom Lane's avatar
    In XLogReadBufferExtended, don't assume P_NEW yields consecutive pages. · 6f2aead1
    Tom Lane authored
    In a database that's not yet reached consistency, it's possible that some
    segments of a relation are not full-size but are not the last ones either.
    Because of the way smgrnblocks() works, asking for a new page with P_NEW
    will fill in the last not-full-size segment --- and if that makes it full
    size, the apparent EOF of the relation will increase by more than one page,
    so that the next P_NEW request will yield a page past the next consecutive
    one.  This breaks the relation-extension logic in XLogReadBufferExtended,
    possibly allowing a page update to be applied to some page far past where
    it was intended to go.  This appears to be the explanation for reports of
    table bloat on replication slaves compared to their masters, and probably
    explains some corrupted-slave reports as well.
    
    Fix the loop to check the page number it actually got, rather than merely
    Assert()'ing that dead reckoning got it to the desired place.  AFAICT,
    there are no other places that make assumptions about exactly which page
    they'll get from P_NEW.
    
    Problem identified by Greg Stark, though this is not the same as his
    proposed patch.
    
    It's been like this for a long time, so back-patch to all supported
    branches.
    6f2aead1
xlogutils.c 13.7 KB