• Tom Lane's avatar
    Fix cidin() to handle values above 2^31 platform-independently. · 6f13a682
    Tom Lane authored
    CommandId is declared as uint32, and values up to 4G are indeed legal.
    cidout() handles them properly by treating the value as unsigned int.
    But cidin() was just using atoi(), which has platform-dependent behavior
    for values outside the range of signed int, as reported by Bart Lengkeek
    in bug #14379.  Use strtoul() instead, as xidin() does.
    
    In passing, make some purely cosmetic changes to make xidin/xidout
    look more like cidin/cidout; the former didn't have a monopoly on
    best practice IMO.
    
    Neither xidin nor cidin make any attempt to throw error for invalid input.
    I didn't change that here, and am not sure it's worth worrying about
    since neither is really a user-facing type.  The point is just to ensure
    that indubitably-valid inputs work as expected.
    
    It's been like this for a long time, so back-patch to all supported
    branches.
    
    Report: <20161018152550.1413.6439@wrigleys.postgresql.org>
    6f13a682
xid.c 4.54 KB