• Tom Lane's avatar
    Reject empty names and recursion in config-file include directives. · 6e421305
    Tom Lane authored
    An empty file name or subdirectory name leads join_path_components() to
    just produce the parent directory name, which leads to weird failures or
    recursive inclusions.  Let's throw a specific error for that.  It takes
    only slightly more code to detect all-blank names, so do so.
    
    Also, detect direct recursion, ie a file calling itself.  As coded
    this will also detect recursion via "include_dir '.'", which is
    perhaps more likely than explicitly including the file itself.
    
    Detecting indirect recursion would require API changes for guc-file.l
    functions, which seems not worth it since extensions might call them.
    The nesting depth limit will catch such cases eventually, just not
    with such an on-point error message.
    
    In passing, adjust the example usages in postgresql.conf.sample
    to perhaps eliminate the problem at the source: there's no reason
    for the examples to suggest that an empty value is valid.
    
    Per a trouble report from Brent Bates.  Back-patch to 9.5; the
    issue is old, but the code in 9.4 is enough different that the
    patch doesn't apply easily, and it doesn't seem worth the trouble
    to fix there.
    
    Ian Barwick and Tom Lane
    
    Discussion: https://postgr.es/m/8c8bcbca-3bd9-dc6e-8986-04a5abdef142@2ndquadrant.com
    6e421305
guc-file.l 32.3 KB