• Tom Lane's avatar
    On Windows, wait a little to see if ERROR_ACCESS_DENIED goes away. · 6d7547c2
    Tom Lane authored
    Attempting to open a file fails with ERROR_ACCESS_DENIED if the file
    is flagged for deletion but not yet actually gone (another in a long
    list of reasons why Windows is broken, if you ask me).  This seems
    likely to explain a lot of irreproducible failures we see in the
    buildfarm.  This state generally persists for only a millisecond or so,
    so just wait a bit and retry.  If it's a real permissions problem,
    we'll eventually give up and report it as such.  If it's the pending
    deletion case, we'll see file-not-found and report that after the
    deletion completes, and the caller will treat that in an appropriate
    way.
    
    In passing, rejigger the existing retry logic for some other error
    cases so that we don't uselessly wait an extra time when we're
    not going to retry anymore.
    
    Alexander Lakhin (with cosmetic tweaks by me).  Back-patch to all
    supported branches, since this seems like a pretty safe change and
    the problem is definitely real.
    
    Discussion: https://postgr.es/m/16161-7a985d2f1bbe8f71@postgresql.org
    6d7547c2
open.c 5.05 KB