• Alexander Korotkov's avatar
    Improve handling of NULLs in KNN-GiST and KNN-SP-GiST · 6cae9d2c
    Alexander Korotkov authored
    This commit improves subject in two ways:
    
     * It removes ugliness of 02f90879, which stores distance values and null
       flags in two separate arrays after GISTSearchItem struct.  Instead we pack
       both distance value and null flag in IndexOrderByDistance struct.  Alignment
       overhead should be negligible, because we typically deal with at most few
       "col op const" expressions in ORDER BY clause.
     * It fixes handling of "col op NULL" expression in KNN-SP-GiST.  Now, these
       expression are not passed to support functions, which can't deal with them.
       Instead, NULL result is implicitly assumed.  It future we may decide to
       teach support functions to deal with NULL arguments, but current solution is
       bugfix suitable for backpatch.
    
    Reported-by: Nikita Glukhov
    Discussion: https://postgr.es/m/826f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru
    Author: Nikita Glukhov
    Reviewed-by: Alexander Korotkov
    Backpatch-through: 9.4
    6cae9d2c
spgscan.c 26.1 KB