• Kevin Grittner's avatar
    Throw error if expiring tuple is again updated or deleted. · 6868ed74
    Kevin Grittner authored
    This prevents surprising behavior when a FOR EACH ROW trigger
    BEFORE UPDATE or BEFORE DELETE directly or indirectly updates or
    deletes the the old row.  Prior to this patch the requested action
    on the row could be silently ignored while all triggered actions
    based on the occurence of the requested action could be committed.
    One example of how this could happen is if the BEFORE DELETE
    trigger for a "parent" row deleted "children" which had trigger
    functions to update summary or status data on the parent.
    
    This also prevents similar surprising problems if the query has a
    volatile function which updates a target row while it is already
    being updated.
    
    There are related issues present in FOR UPDATE cursors and READ
    COMMITTED queries which are not handled by this patch.  These
    issues need further evalution to determine what change, if any, is
    needed.
    
    Where the new error messages are generated, in most cases the best
    fix will be to move code from the BEFORE trigger to an AFTER
    trigger.  Where this is not feasible, the trigger can avoid the
    error by re-issuing the triggering statement and returning NULL.
    
    Documentation changes will be submitted in a separate patch.
    
    Kevin Grittner and Tom Lane with input from Florian Pflug and
    Robert Haas, based on problems encountered during conversion of
    Wisconsin Circuit Court trigger logic to plpgsql triggers.
    6868ed74
triggers.out 69.8 KB