• Tom Lane's avatar
    Avoid unnecessary failure in SELECT concurrent with ALTER NO INHERIT. · 680d5405
    Tom Lane authored
    If a query against an inheritance tree runs concurrently with an ALTER
    TABLE that's disinheriting one of the tree members, it's possible to get
    a "could not find inherited attribute" error because after obtaining lock
    on the removed member, make_inh_translation_list sees that its columns
    have attinhcount=0 and decides they aren't the columns it's looking for.
    
    An ideal fix, perhaps, would avoid including such a just-removed member
    table in the query at all; but there seems no way to accomplish that
    without adding expensive catalog rechecks or creating a likelihood of
    deadlocks.  Instead, let's just drop the check on attinhcount.  In this
    way, a query that's included a just-disinherited child will still
    succeed, which is not a completely unreasonable behavior.
    
    This problem has existed for a long time, so back-patch to all supported
    branches.  Also add an isolation test verifying related behaviors.
    
    Patch by me; the new isolation test is based on Kyotaro Horiguchi's work.
    
    Discussion: https://postgr.es/m/20170626.174612.23936762.horiguchi.kyotaro@lab.ntt.co.jp
    680d5405
alter-table-4.out 1.38 KB