• Tom Lane's avatar
    Fix ANALYZE's ancient deficiency of not trying to collect stats for expression · 67becf8d
    Tom Lane authored
    indexes when the index column type (the opclass opckeytype) is different from
    the expression's datatype.  When coded, this limitation wasn't worth worrying
    about because we had no intelligence to speak of in stats collection for the
    datatypes used by such opclasses.  However, now that there's non-toy
    estimation capability for tsvector queries, it amounts to a bug that ANALYZE
    fails to do this.
    
    The fix changes struct VacAttrStats, and therefore constitutes an API break
    for custom typanalyze functions.  Therefore we can't back-patch it into
    released branches, but it was agreed that 9.0 isn't yet frozen hard enough
    to make such a change unacceptable.  Ergo, back-patch to 9.0 but no further.
    The API break had better be mentioned in 9.0 release notes.
    67becf8d
analyze.c 78.4 KB