• Heikki Linnakangas's avatar
    Remove dead NULL-pointer checks in GiST code. · 670bf71f
    Heikki Linnakangas authored
    gist_poly_compress() and gist_circle_compress() checked for a NULL-pointer
    key argument, but that was dead code; the gist code never passes a
    NULL-pointer to the "compress" method.
    
    This commit also removes a documentation note added in commit a0a3883d,
    about doing NULL-pointer checks in the "compress" method. It was added
    based on the fact that some implementations were doing NULL-pointer
    checks, but those checks were unnecessary in the first place.
    
    The NULL-pointer check in gbt_var_same() function was also unnecessary.
    The arguments to the "same" method come from the "compress", "union", or
    "picksplit" methods, but none of them return a NULL pointer.
    
    None of this is to be confused with SQL NULL values. Those are dealt with
    by the gist machinery, and are never passed to the GiST opclass methods.
    
    Michael Paquier
    670bf71f
gist.sgml 29.6 KB