• Tom Lane's avatar
    Avoid crash in eval_const_expressions if a Param's type changes. · 662d12ae
    Tom Lane authored
    Since commit 6719b238 it's been possible for the values of plpgsql
    record field variables to be exposed to the planner as Params.
    (Before that, plpgsql never supplied values for such variables during
    planning, so that the problematic code wasn't reached.)  Other places
    that touch potentially-type-mutable Params either cope gracefully or
    do runtime-test-and-ereport checks that the type is what they expect.
    But eval_const_expressions() just had an Assert, meaning that it either
    failed the assertion or risked crashes due to using an incompatible
    value.
    
    In this case, rather than throwing an ereport immediately, we can just
    not perform a const-substitution in case of a mismatch.  This seems
    important for the same reason that the Param fetch was speculative:
    we might not actually reach this part of the expression at runtime.
    
    Test case will follow in a separate commit.
    
    Patch by me, pursuant to bug report from Andrew Gierth.
    Back-patch to v11 where the previous commit appeared.
    
    Discussion: https://postgr.es/m/87wotkfju1.fsf@news-spur.riddles.org.uk
    662d12ae
clauses.c 160 KB